[Backport 5.0] No team cycles #49621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This change introduces a check on `UpdateTeam` to not introduce a circular parent relationship. The check effectively finds all teams that _are not descendants_ (so not in the subtree of) modified team, and looks whether the parent is there. It is only safe to set the parent team ID to a team outside of modified team's own descendants. ## Test plan * Testing database stores with Postgres. * Testing GraphQL API with fakes. (cherry picked from commit da92373)
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits cc87a97 and 530863b or learn more. Open explanation
|
cbart
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a check on
UpdateTeamto not introduce a circular parent relationship.The check effectively finds all teams that are not descendants (so not in the subtree of) modified team, and looks whether the parent is there. It is only safe to set the parent team ID to a team outside of modified team's own descendants.
Test plan
Backport da92373 from No team cycles #49556