rbac: fix bug with selecting permissions in PermissionList #50033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courier-new
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Is there a story with multiple roles/should we make one?
There was a problem hiding this comment.
The Roles Management page story already exists for this.
The storybook link for this PR wasn't generated (my guess because I didn't add a new storybook, only modified the existing one).
There was a problem hiding this comment.
Ooh this is perfect, thanks for confirming this for me! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When multiple role nodes are expanded, clicking on the label for any permissions toggles the
onClickmethod for the most recently expanded role node.Test plan
App preview:
Check out the client app preview documentation to learn more.