batches: add settings for org level batch changes admin #50604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courier-new
approved these changes
Apr 25, 2023
BolajiOlajide
force-pushed
the
bo/allow-org-level-batch-changes-admin-setting
branch
from
313e6cf
to
1e81c60
Compare
BolajiOlajide
deleted the
bo/allow-org-level-batch-changes-admin-setting
branch
|
Ha, not that it matters much, but I think you committed my suggestions on GitHub but then rebased and force-pushed from your local branch without pulling them first, so they got overwritten. 😜 |
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2023
(cherry picked from commit ce79296)
keegancsmith
pushed a commit
that referenced
this pull request
May 31, 2023
#52656) Part 1 #50447 This PR adds a new settings field for org admins to specify if all members of the Org are Batch Changes admin. With this, org-members who are not site administrators can execute/apply/run batch changes in the org namespace. Backport ce79296 from #50604 Co-authored-by: Bolaji Olajide <25608335+BolajiOlajide@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 #50447
This PR adds a new settings field for org admins to specify if all members of the Org are Batch Changes admin. With this, org-members who are not site administrators can execute/apply/run batch changes in the org namespace.
Test plan
Just a settings field addition. A quick test is to open the settings editor and enter
orgs.allMembersBatchChangesAdminin the editor, it should be a valid field.