-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow disabling of user centric or repo centric permission sync #51255
feat: allow disabling of user centric or repo centric permission sync #51255
Conversation
This is beneficial in cases where one or the other is clearly much faster. It is also beneficial in cases when we have a clash between user centric and repo centric permission sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense and is definitely backward-compatible. The code LGTM. Thanks for the nicely structured tests!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.0 5.0
# Navigate to the new working tree
cd .worktrees/backport-5.0
# Create a new branch
git switch --create backport-51255-to-5.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cec1bee34e42249243080192f593039b3ca0db04
# Push it to GitHub
git push --set-upstream origin backport-51255-to-5.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.0 Then, create a pull request where the |
## Test plan No test, only changelog change
…permission sync (#51255) This is beneficial in cases where one or the other is clearly much faster. It is also beneficial in cases when we have a clash between user centric and repo centric permission sync. It's basically just a site config schema change. Tested locally + unit tests. (cherry picked from commit cec1bee)
This is beneficial in cases where one or the other is clearly much faster. It is also beneficial in cases when we have a clash between user centric and repo centric permission sync.
Test plan
It's basically just a site config schema change. Tested locally + unit tests.