Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site configs with example values #51919

Merged
merged 10 commits into from
May 15, 2023
Merged

Update site configs with example values #51919

merged 10 commits into from
May 15, 2023

Conversation

Rhia2
Copy link
Contributor

@Rhia2 Rhia2 commented May 15, 2023

Update site configs with example values

Test plan

No review required

@Rhia2 Rhia2 requested a review from indradhanush May 15, 2023 10:35
@cla-bot cla-bot bot added the cla-signed label May 15, 2023
@Rhia2 Rhia2 requested a review from airamare01 May 15, 2023 10:51
@Rhia2 Rhia2 changed the title Rhia2 1 (#51918) Update site configs with example values May 15, 2023
Copy link
Contributor

@airamare01 airamare01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendous change! Thanks for adding these @Rhia2

@Rhia2
Copy link
Contributor Author

Rhia2 commented May 15, 2023

Original pr was closed because it was made from a fork.

Copy link
Contributor

@indradhanush indradhanush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Rhia2 Rhia2 merged commit 40fe3a7 into main May 15, 2023
@Rhia2 Rhia2 deleted the rhia2-1 branch May 15, 2023 12:13
cesrjimenez pushed a commit that referenced this pull request May 17, 2023
Update site configs with example values

## Test plan
No review required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants