Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "syntax-highlighter: scip-ctags implementation (#50600)" #52642

Merged
merged 1 commit into from
May 30, 2023
Merged

Revert "syntax-highlighter: scip-ctags implementation (#50600)" #52642

merged 1 commit into from
May 30, 2023

Conversation

efritz
Copy link
Contributor

@efritz efritz commented May 30, 2023 •
edited
Loading

This reverts commit 1ff6fb1.

Test plan

Rebort.

@cla-bot cla-bot bot added the cla-signed label May 30, 2023
jhchabran
jhchabran approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@jhchabran jhchabran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:stamp: revert

@efritz efritz enabled auto-merge (squash) May 30, 2023 18:16
@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in CODENOTIFY files for diff 7e1e59d...0ba31e7.

Notify File(s)
@bobheadxi monitoring/go.mod
monitoring/go.sum
@keegancsmith cmd/symbols/Dockerfile
cmd/symbols/Dockerfile.bazel
cmd/symbols/build-bazel.sh
cmd/symbols/build-ctags.sh
cmd/symbols/cargo-config.sh
cmd/symbols/ctags-install-alpine.sh
cmd/symbols/internal/api/BUILD.bazel
cmd/symbols/internal/api/handler_test.go
cmd/symbols/parser/BUILD.bazel
cmd/symbols/parser/config.go
cmd/symbols/parser/parser.go
cmd/symbols/parser/parser_pool.go
cmd/symbols/shared/BUILD.bazel
cmd/symbols/shared/sqlite.go
cmd/symbols/types/types.go
@slimsag monitoring/go.mod
monitoring/go.sum
@sourcegraph/delivery monitoring/go.mod
monitoring/go.sum

@efritz efritz merged commit 9554353 into main May 30, 2023
@efritz efritz deleted the ef/revert branch May 30, 2023 18:29
ErikaRS pushed a commit that referenced this pull request Jun 22, 2023
@efritz @ErikaRS
Revert "syntax-highlighter: scip-ctags implementation (#50600)" (#52642)
eadb67a 
This reverts commit 1ff6fb1.



## Test plan

<!-- All pull requests REQUIRE a test plan:
https://docs.sourcegraph.com/dev/background-information/testing_principles
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhchabran jhchabran jhchabran approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efritz @sourcegraph-bot @jhchabran