[Backport-5.0] [fix] fixes for mau calculations in product analytics (#52581) #52682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes MAU calculation in usage analytics in the product. Previously we were filtering out the backend events, but as part of was not part of the BuildCommonUsageConds in the event_logs. However event_logs also add this condition directly in the query string, which I did not notice. Also, our timestamp calculation suffered from an edge case, where the from time was not calculated right, e.g. on dates like `2023-04-30T23:59:00Z`. Tested locally and with customer data + added unit tests. (cherry picked from commit ee6e66e)
keegancsmith
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #52581
Test plan
Unit tests