Cody for Windows installer: builds/signs x64 msi. #53832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonjr
force-pushed
the
nelsona/cody-win-installer
branch
from
32b8ccb
to
8a14558
Compare
peterguy
approved these changes
Jun 22, 2023
daxmc99
reviewed
Jun 23, 2023
| @@ -0,0 +1,28 @@ | |||
| $target = $args[0] | |||
|
|
|||
| echo "Signing: ${target} | ${env:STORE_TYPE}/${env:STORE_KEY}/${env:STORE_ALIAS}/${env:STORE_CERT}" | |||
There was a problem hiding this comment.
I'm no Windows expert but looks like we could automate some of the codesigning?
https://tauri.app/v1/guides/distribution/sign-windows#bonus-sign-your-application-with-github-actions
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installer assumes you first ran
./enterprise/dev/app/build-windows.sh.Test plan
<root>/windows/installer/codybuild.cmd