Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable servers to run on Windows OS. #54233

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Enable servers to run on Windows OS. #54233

merged 4 commits into from
Jun 27, 2023

Conversation

nelsonjr
Copy link
Contributor

Test plan

  • Changes on non-Windows OS are no-op
  • Changed on Windows are manually verified.

@cla-bot cla-bot bot added the cla-signed label Jun 27, 2023
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Jun 27, 2023 •
edited
Loading

Codenotify: Notifying subscribers in CODENOTIFY files for diff b9287b1...f88821e.

Notify File(s)
@keegancsmith internal/vcs/BUILD.bazel
internal/vcs/url.go
internal/vcs/url_posix.go
internal/vcs/url_windows.go
@slimsag cmd/blobstore/internal/blobstore/BUILD.bazel
cmd/blobstore/internal/blobstore/blobstore.go
cmd/blobstore/internal/blobstore/blobstore_posix.go
cmd/blobstore/internal/blobstore/blobstore_windows.go

slimsag
slimsag approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@slimsag slimsag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed to make sure the changes are isolated to windows only, I am confident in that, so LGTM then.

@nelsonjr nelsonjr force-pushed the nelsona/cody-app-embeddings branch from f0458d4 to 398eb10 Compare June 27, 2023 07:24
@nelsonjr nelsonjr enabled auto-merge (squash) June 27, 2023 08:08
@nelsonjr nelsonjr merged commit be45c5c into main Jun 27, 2023
9 checks passed
@nelsonjr nelsonjr deleted the nelsona/cody-app-embeddings branch June 27, 2023 09:04
@nelsonjr nelsonjr mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimsag slimsag slimsag approved these changes

@limitedmage limitedmage Awaiting requested review from limitedmage

@peterguy peterguy Awaiting requested review from peterguy

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nelsonjr @sourcegraph-bot @slimsag