docs: update docs for user deletion #54915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that deleting a user also removes their repository permissions.
BolajiOlajide
approved these changes
Jul 13, 2023
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 64d09f3...fce8807.
|
mrnugget
reviewed
Jul 13, 2023
| @@ -597,6 +597,7 @@ func (u *userStore) Update(ctx context.Context, id int32, update UserUpdate) (er | |||
| } | |||
|
|
|||
| // Delete performs a soft-delete of the user and all resources associated with this user. | |||
| // Permissions for soft-deleted users are removed from the user_repo_permissions table via a trigger. | |||
There was a problem hiding this comment.
Nitpick: I would've added this below line 651 as a separate line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that deleting a user also removes their repository permissions.
Test plan
N/A: Just a comment change and docs update.