Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

bazel: patch rules_oci to run tar with --no-xattrs #61004

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

Strum355
Copy link
Contributor

@Strum355 Strum355 commented Mar 11, 2024

Workaround for https://github.com/sourcegraph/devx-support/issues/622. This is portable between both bsdtar and gnutar. On gnutar, this is the default, so this changes nothing for CI builds. This only changes behaviour in macOS with bsdtar.

It is unclear to me where a final solution will exist:

Test plan

Had Christoph run bazel run //cmd/batcheshelper:image_tarball, which succeeded with this patch

@cla-bot cla-bot bot added the cla-signed label Mar 11, 2024
@Strum355 Strum355 self-assigned this Mar 11, 2024
@Strum355 Strum355 added the bazel label Mar 11, 2024
@Strum355 Strum355 marked this pull request as ready for review March 11, 2024 19:22
@Strum355 Strum355 enabled auto-merge (squash) March 11, 2024 19:25
@Strum355 Strum355 merged commit 463f11a into main Mar 11, 2024
17 checks passed
@Strum355 Strum355 deleted the nsc/docker-xsetattr branch March 11, 2024 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants