Include sbin in path when running podman network command #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `podman network` commands, if the selected storage driver relies in an executable in the PATH, then the podman command must be run with that executable available. In the case of ZFS storage driver, the `zfs` binary may be in /usr/sbin, so this commit adds the sbin directories to the PATHs. In all other places in the module, the PATH is set to include both bin and sbin directories, the podman::network defined type is the only place I could find where sbin was missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
podman networkcommands, if the selected storage driverrelies in an executable in the PATH, then the podman command must
be run with that executable available. In the case of ZFS storage
driver, the
zfsbinary may be in /usr/sbin, so this commit addsthe sbin directories to the PATHs.
In all other places in the module, the PATH is set to include both
bin and sbin directories, the podman::network defined type is the
only place I could find where sbin was missing.
Also strips an errant double quote which was introduced during a refactoring.