add safeguard

sp-nitech · Oct 19, 2023 · 195b986 · 195b986
1 parent 37beca3
commit 195b986
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/math/statistics_accumulation.cc b/src/math/statistics_accumulation.cc
@@ -133,7 +133,7 @@ bool StatisticsAccumulation::GetStandardDeviation(
 bool StatisticsAccumulation::GetFullCovariance(
     const StatisticsAccumulation::Buffer& buffer,
     SymmetricMatrix* full_covariance) const {
-  if (!is_valid_ || num_statistics_order_ < 2 ||
+  if (!is_valid_ || num_statistics_order_ < 2 || diagonal_ ||
       buffer.zeroth_order_statistics_ <= 0 || NULL == full_covariance) {
     return false;
   }
@@ -162,7 +162,7 @@ bool StatisticsAccumulation::GetFullCovariance(
 bool StatisticsAccumulation::GetUnbiasedCovariance(
     const StatisticsAccumulation::Buffer& buffer,
     SymmetricMatrix* unbiased_covariance) const {
-  if (!is_valid_ || num_statistics_order_ < 2 ||
+  if (!is_valid_ || num_statistics_order_ < 2 || diagonal_ ||
       buffer.zeroth_order_statistics_ <= 1 || NULL == unbiased_covariance) {
     return false;
   }
@@ -185,7 +185,8 @@ bool StatisticsAccumulation::GetUnbiasedCovariance(
 bool StatisticsAccumulation::GetCorrelation(
     const StatisticsAccumulation::Buffer& buffer,
     SymmetricMatrix* correlation) const {
-  if (!is_valid_ || num_statistics_order_ < 2 || NULL == correlation) {
+  if (!is_valid_ || num_statistics_order_ < 2 || diagonal_ ||
+      NULL == correlation) {
     return false;
   }