simplify equation

sp-nitech · Nov 1, 2023 · da31754 · da31754
1 parent 8163414
commit da31754
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/math/statistics_accumulation.cc b/src/math/statistics_accumulation.cc
@@ -382,8 +382,7 @@ bool StatisticsAccumulation::Merge(
       for (int i(0); i <= num_order_; ++i) {
         for (int j(diagonal_ ? i : 0); j <= i; ++j) {
           buffer->second_order_statistics_[i][j] +=
-              second[i][j] + c * ((mu1[i] * mu1[j] + mu2[i] * mu2[j]) -
-                                  (mu1[i] * mu2[j] + mu2[i] * mu1[j]));
+              second[i][j] + c * (mu1[i] - mu2[i]) * (mu1[j] - mu2[j]);
         }
       }
     } else {

diff --git a/src/utils/misc_utils.cc b/src/utils/misc_utils.cc
@@ -315,10 +315,9 @@ bool ComputeLowerAndUpperBounds(double confidence_level, int num_data,
                                 const std::vector<double> variance,
                                 std::vector<double>* lower_bound,
                                 std::vector<double>* upper_bound) {
-  if (confidence_level <= 0.0 ||
-      100.0 <= confidence_level ||
-      num_data <= 0 || mean.size() != variance.size() ||
-      NULL == lower_bound || NULL == upper_bound) {
+  if (confidence_level <= 0.0 || 100.0 <= confidence_level || num_data <= 0 ||
+      mean.size() != variance.size() || NULL == lower_bound ||
+      NULL == upper_bound) {
     return false;
   }