[Merged by Bors] - Make dependabot ignore libp2p libs #6018
Conversation
Following observed address mechanism breakage in libp2p/go-libp2p#2793 disable automatic libp2p dependency bumps. Prerequisite for re-enabling automatic updates of libp2p libs: QUIC and routing discovery systests
|
Please add a comment to the dependabot file and add an issue for adding system tests with QUIC such that we enable it again. I want to avoid falling too far behind with dependency updates. Has the problem been reported to libp2p? I don't see an issue that mentions that problem in the libp2p repository? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6018 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 296 296
Lines 31683 31683
=========================================
- Hits 25789 25781 -8
- Misses 4212 4218 +6
- Partials 1682 1684 +2 ☔ View full report in Codecov by Sentry. |
|
@pigmej well there were a few hours between my comment and the creation of the PR 😉 then this PR isn't needed any more is it? the fix was already approved and will (probably) land in the next libp2p release. We only need to downgrade it now, close the PR dependabot creates for |
|
This PR is still needed as that's not the first instance of a libp2p update breaking go-spacemesh. |
Done: #6025 |
|
bors merge |
## Motivation libp2p/go-libp2p#2793 broke observed address handling and consequently routing discovery mechanism, too. This is not the first time we're having problems because of (semi-)automatic libp2p dependency updates. Prerequisite for re-enabling automatic updates of libp2p libs: QUIC and routing discovery systests
|
Build failed: |
|
bors merge |
## Motivation libp2p/go-libp2p#2793 broke observed address handling and consequently routing discovery mechanism, too. This is not the first time we're having problems because of (semi-)automatic libp2p dependency updates. Prerequisite for re-enabling automatic updates of libp2p libs: QUIC and routing discovery systests
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Motivation
libp2p/go-libp2p#2793 broke observed address handling and consequently routing discovery mechanism, too.
This is not the first time we're having problems because of (semi-)automatic libp2p dependency updates.
Prerequisite for re-enabling automatic updates of libp2p libs: QUIC and routing discovery systests
Description
Add dependabot exception for libp2p libraries