feat: let SIM210 return expressions without bool() wrapping (astral-s…

…h#2410)
spaceone · Jan 31, 2023 · ff77eb5 · ff77eb5
1 parent 84a8b62
commit ff77eb5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/src/rules/flake8_simplify/rules/ast_ifexp.rs b/src/rules/flake8_simplify/rules/ast_ifexp.rs
@@ -35,18 +35,19 @@ pub fn explicit_true_false_in_ifexpr(
         Range::from_located(expr),
     );
     if checker.patch(diagnostic.kind.rule()) {
+        let bool_expr = match test.node {
+            ExprKind::Compare { .. } => test.clone(),
+            _ => create_expr(ExprKind::Call {
+                func: Box::new(create_expr(ExprKind::Name {
+                    id: "bool".to_string(),
+                    ctx: ExprContext::Load,
+                })),
+                args: vec![test.clone()],
+                keywords: vec![],
+            }),
+        };
         diagnostic.amend(Fix::replacement(
-            unparse_expr(
-                &create_expr(ExprKind::Call {
-                    func: Box::new(create_expr(ExprKind::Name {
-                        id: "bool".to_string(),
-                        ctx: ExprContext::Load,
-                    })),
-                    args: vec![test.clone()],
-                    keywords: vec![],
-                }),
-                checker.stylist,
-            ),
+            unparse_expr(&bool_expr, checker.stylist),
             expr.location,
             expr.end_location.unwrap(),
         ));

diff --git a/...ules/flake8_simplify/snapshots/ruff__rules__flake8_simplify__tests__SIM210_SIM210.py.snap b/...ules/flake8_simplify/snapshots/ruff__rules__flake8_simplify__tests__SIM210_SIM210.py.snap
@@ -32,7 +32,7 @@ expression: diagnostics
     column: 29
   fix:
     content:
-      - bool(b != c)
+      - b != c
     location:
       row: 3
       column: 4