Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin glue-jupyter to 0.22.2+ #139

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Sep 5, 2024

This pins glue-jupyter to 0.22.2+ (the pinned jdaviz only requires 0.22.1+) to ensure glue-viz/glue-jupyter#467 is included.

@kecnry kecnry added the trivial no review required label Sep 5, 2024
@kecnry kecnry added this to the 0.4.3 milestone Sep 5, 2024
@kecnry kecnry marked this pull request as ready for review September 5, 2024 13:30
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (7b78df5) to head (88f189b).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   93.92%   91.20%   -2.73%     
==========================================
  Files          37       41       +4     
  Lines        1598     2148     +550     
==========================================
+ Hits         1501     1959     +458     
- Misses         97      189      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry merged commit 041766f into spacetelescope:main Sep 5, 2024
12 of 13 checks passed
@kecnry kecnry deleted the pin-glue-jupyter branch September 5, 2024 13:44
meeseeksmachine pushed a commit to meeseeksmachine/lcviz that referenced this pull request Sep 5, 2024
kecnry added a commit that referenced this pull request Sep 5, 2024
Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial no review required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant