-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for custom HTML in riot-web homepage #55
Enable support for custom HTML in riot-web homepage #55
Conversation
anadahz
commented
Dec 8, 2018
- Add default template file for homepage HTML
- Add default riot-web config options for homepage
Calling the variable something like I also wonder whether using and maintaining our own copy of riot-web's On the other hand it's nice we can point it to our own "Riot Bot" (or rather, not show that at all). So maybe it's worth going to the trouble and doing it.. |
e64c264
to
1fb4c50
Compare
Indeed it makes more sense to use this variable instead, I changed the variables accordingly.
According to the commits history of home.html it seems that is not getting updated so often.
This is being handled by the variable
Good point added the support channel of this playbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found a few more things that should be changed before we can merge this.
Thanks for your work on this! I've submitted a few minor things to be tested/corrected and let's merge this! |
* Add default template file for homepage HTML * Add default riot-web config options for homepage
1fb4c50
to
57bfb97
Compare
Ready for review. |
Small bugfix related to #55
I've merged this and it seems to work! I've only had to remove the Thank you for your work on this! 👍 |
Good catch, thanks! |