Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user agent strings for agent aliases #612

Merged

Conversation

takatea
Copy link
Contributor

@takatea takatea commented Apr 14, 2023

I think user agent aliases of Mechanize looks useful for developer, but actually unusable because they are very old.
They looks need to be updated.

In addition, this PR contains an example to fetch latest user agents from WhatIsMyBrowser.com.
Especially, The service provide APIs and it requires payment, so public web site content may be a preview.
Therefore, to avoid pirating, I did not fully automate this process to update user agent aliases.

@flavorjones
Copy link
Member

Thank you for submitting this! I've kicked off CI and I think this update (and the example which helps keep us up to date) is very helpful.

@flavorjones flavorjones force-pushed the add-example-to-fetch-latest-user-agents branch from 2553cb7 to 18b7efd Compare April 15, 2023 19:58
@flavorjones
Copy link
Member

Looks good. I updated the docstring and will merge this shortly.

@flavorjones flavorjones merged commit 4ab81ef into sparklemotion:main Apr 15, 2023
@takatea
Copy link
Contributor Author

takatea commented Apr 16, 2023

@flavorjones

Thank you so much for docstring update, and thank you for the review and this PR merging!

@flavorjones
Copy link
Member

Just shipped in Release 2.9.1 / 2023-04-17 · sparklemotion/mechanize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants