Some tidy up of code related to UserAvatar #3013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to resolve:
but couldn't reproduce.
Instead, opted out to do some tidying up in the code of some easy and quick to refactor places like isolating non-shared constants and adding
@debt
comments.There is still a lot of debt to be repaid by the
UserAvatar
component, especially in terms of removing the injected classes to achieve robustness and uniformity.