Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using the TrackingPermision from iOS 14.0.0 #308

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

duyhungtnn
Copy link
Contributor

@duyhungtnn duyhungtnn commented Aug 26, 2022

Goal

  • Allow using the TrackingPermision with iOS from iOS 14.0.0

Why?

  • One of my apps targeted iOS 14. It actually tracks users.
  • And I need to request Tracking permission even on the iOS device below iOS 14.5. (from 14.0.0 to 14.4) to make the app tracking function works. Otherwise, no data and no cookies for tracking could save on the app and its in-app web view.
  • I don't know why TrackingPermision required iOS 14.5.
  • I created a fork and change it to available from iOS 14.0.0

@duyhungtnn
Copy link
Contributor Author

@ivanvorobei please take a look at this PR.

@duyhungtnn duyhungtnn changed the title fix : can not use TrackingPermission iOS 14 allow using the TrackingPermision with iOS from iOS 14.0.0 Aug 26, 2022
@duyhungtnn duyhungtnn changed the title allow using the TrackingPermision with iOS from iOS 14.0.0 Allow using the TrackingPermision from iOS 14.0.0 Aug 26, 2022
@duyhungtnn
Copy link
Contributor Author

@ivanvorobei did my PR has a problem somewhere? Could you please let me know?
Actually, It lives in my product app and working, so I wanna know.

@ivanvorobei
Copy link
Member

@duyhungtnn hey sorry for delay!
I was busy my new project. I think you right, and thanks for PR. I will merge it tomorrow

@ivanvorobei ivanvorobei merged commit b3b87d4 into sparrowcode:main Nov 7, 2022
@ivanvorobei
Copy link
Member

@duyhungtnn thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants