transaction: introduce TxOutput namedtuple #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomberNight
force-pushed
the
txoutput_namedtuple
branch
from
05603bb
to
2eb72d4
Compare
PiRK
added a commit
to PiRK/ElectrumABC
that referenced
this pull request
May 19, 2023
Using a namedtuple is an intermediate step before creating a proper class for this. It encapsulate the 3-tuples and makes the code easier to read (attributes rather than indices) backport of spesmilo#4596 and removal of a bunch of code Transaction methods that are unused.
PiRK
added a commit
to PiRK/ElectrumABC
that referenced
this pull request
May 19, 2023
Using a namedtuple is an intermediate step before creating a proper class for this. It encapsulate the 3-tuples and makes the code easier to read (attributes rather than indices) backport of spesmilo#4596 and removal of a bunch of code Transaction methods that are unused.
PiRK
added a commit
to PiRK/ElectrumABC
that referenced
this pull request
May 22, 2023
Using a namedtuple is an intermediate step before creating a proper class for this. It encapsulate the 3-tuples and makes the code easier to read (attributes rather than indices) backport of spesmilo#4596 and removal of a bunch of code Transaction methods that are unused.
PiRK
added a commit
to Bitcoin-ABC/ElectrumABC
that referenced
this pull request
May 22, 2023
Using a namedtuple is an intermediate step before creating a proper class for this. It encapsulate the 3-tuples and makes the code easier to read (attributes rather than indices) backport of spesmilo#4596 and removal of a bunch of code Transaction methods that are unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #4570
I think it's nicer for us too not to have 3-tuples everywhere;
a data class might have been even better so that it can't be unpacked (in case we introduce a new field).
Also, I think it's better than dicts.