Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix bash functions with root command name #643

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Prefix bash functions with root command name #643

merged 2 commits into from
Feb 28, 2018

Commits on Feb 28, 2018

  1. Prefix bash functions with root command name 

    Prior to this commit the autocomplete bash functions were being prefixed
with the root command name, but references to those functions from
subcommands were having the subcommands prefixed instead - causing the
function lookups to fail and error out.

For example (as observed in kubernetes/kubernetes#60517):

kubectl create -f [Tab] failed with the following message: kubectl
create -f __create_handle_filename_extension_flag: command not found

in this case the function being invoked should be __kubectl_handle_filename_extension_flag

Signed-off-by: John McCabe <john@johnmccabe.net>
    @johnmccabe
    johnmccabe committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    27b77a6 View commit details
    Browse the repository at this point in the history

  2. Test filename extension and subdirs_in_dir for subcommands 

    This commit adds two regex based tests to ensure that the handle
filename extension and handle subdirs in dir functions are prefixed by
the root command when present in subcommands.

Previously they had been prefixed incorrectly with the subcommand name.

Signed-off-by: John McCabe <john@johnmccabe.net>
    @johnmccabe
    johnmccabe committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    cd27850 View commit details
    Browse the repository at this point in the history