Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid genindex.html file produced with translated docs #12495

Conversation

n-peugnet
Copy link
Contributor

Subject: Fix invalid genindex.html file produced with translated docs

Feature or Bugfix

  • Bugfix

Purpose

As the index generator checks for None, we should continue to set this value to None instead of an empty string:

if category_key is not None:
return category_key

Detail

@n-peugnet n-peugnet force-pushed the fix-messed-up-genindex-in-translations branch from a4b2d22 to 90b948b Compare June 30, 2024 14:10
Copy link
Contributor

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (confirmed test coverage both without + with fix, and built the minimal repro case both without + with the fix also).

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great cheers

@chrisjsewell chrisjsewell merged commit b23ac4f into sphinx-doc:master Jul 4, 2024
23 checks passed
@n-peugnet n-peugnet deleted the fix-messed-up-genindex-in-translations branch July 4, 2024 11:00
@AA-Turner AA-Turner added this to the 7.4.0 milestone Jul 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate letter in genindex.html in translated html build
4 participants