Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick IntervalMonthDayNano to String #4

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

y-f-u
Copy link

@y-f-u y-f-u commented Jun 24, 2024

cherry pick upstream IntervalMonthDayNano to String apache#10956

…che#10956)

* support to unparse ScalarValue::IntervalMonthDayNano to String

* use array formatter to format the interval string
@y-f-u y-f-u force-pushed the cherry-pick-IntervalMonthDayNano branch from 4568642 to 0a4f3bf Compare June 24, 2024 03:40
@y-f-u y-f-u changed the title Cherry pick interval month day nano Cherry pick IntervalMonthDayNano to String Jun 24, 2024
@y-f-u y-f-u merged commit 6d59ff9 into spiceai-39 Jun 24, 2024
@y-f-u y-f-u deleted the cherry-pick-IntervalMonthDayNano branch June 24, 2024 03:42
sgrebnov pushed a commit that referenced this pull request Sep 2, 2024
* Make `CommonSubexprEliminate` top-down like

* fix top-down recursion, fix unit tests to use real a Optimizer to verify behavior on plans

* Extract result of `find_common_exprs` into a struct (#4)

* Extract the result of find_common_exprs into a struct

* Make naming consistent

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants