feat: Album-Art Based Color Shifting #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieS1103
requested review from
theRealPadster
and removed request for
a team
kyrie25
requested changes
Dec 3, 2022
packages/marketplace/src/components/Modals/Settings/ConfigRow.tsx
Outdated
Show resolved
Hide resolved
packages/marketplace/src/components/Modals/Settings/ConfigRow.tsx
Outdated
Show resolved
Hide resolved
packages/marketplace/src/components/Modals/Settings/ConfigRow.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
Co-authored-by: Nam Anh <phamnamanh25@gmail.com>
kyrie25
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to edit the title before we merge, just thought it'd be funny.
This code isn't as clean as it can be of course, which is what I assume the review process will help with, however it does work.
New libraries/ api's used
When the song changes, it will get the main color of the album art using node vibrant,
it will then generate a scheme using thecolorapi
and the final library used is chroma, in order to sort the scheme the user actively has installed by the amount of contrast between each color
To elaborate on some things, the reason I sort the colorMap based on the relative distance between the colors is so I can get it to approximately match the order that the schemes colorapi provides are ordered in, meaning the text and the main colors should always contrast each other rather nicely. This does cause all the schemes to have a dark background with a light text so I might allow the users to change the mode colorapi generates the schemes or change the way I order them (use saturation, lumination, or some other value).