Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): sort by creation date #611

Merged
merged 3 commits into from
Oct 13, 2023
Merged

feat(grid): sort by creation date #611

merged 3 commits into from
Oct 13, 2023

Conversation

SunsetTechuila
Copy link
Contributor

@SunsetTechuila SunsetTechuila commented Oct 12, 2023

the "newest" and "oldest" sorting options are actually responsible for sorting by last update date, which doesn't match their names, so I renamed them to "recently updated" and "most stale" and added sorting by repository creation date

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner October 12, 2023 14:20
@SunsetTechuila SunsetTechuila requested review from rxri and removed request for a team October 12, 2023 14:20
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Could we change it to be "last updated" though, instead of "recently updated"?

@theRealPadster theRealPadster merged commit effcbce into spicetify:main Oct 13, 2023
5 checks passed
@SunsetTechuila SunsetTechuila deleted the your-ad-could-be-here branch October 13, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants