Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to pnpm #617

Merged
merged 7 commits into from
Oct 18, 2023
Merged

feat: migrate to pnpm #617

merged 7 commits into from
Oct 18, 2023

Conversation

SunsetTechuila
Copy link
Contributor

No description provided.

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner October 16, 2023 21:36
@SunsetTechuila SunsetTechuila requested review from rxri and removed request for a team October 16, 2023 21:36
@SunsetTechuila SunsetTechuila mentioned this pull request Oct 16, 2023
Merged
@rxri rxri changed the title chore(ci): update actions feat: migrate to pnpm Oct 17, 2023
@theRealPadster
Copy link
Member

Is this all tested and good to go now?

@SunsetTechuila
Copy link
Contributor Author

don't we need to add all yarn and npm files to gitignore or only allow pnpm?

@theRealPadster
Copy link
Member

don't we need to add all yarn and npm files to gitignore or only allow pnpm?

I don't think we need to, but it would be a good idea, yes

@SunsetTechuila
Copy link
Contributor Author

What exactly is a good idea? Add to gitignore or allow only pnpm?

@theRealPadster
Copy link
Member

Add the files to .gitignore, so people don't accidentally commit them. I'm not sure how you'd only allow pnpm.

@SunsetTechuila
Copy link
Contributor Author

I'm not sure how you'd only allow pnpm

https://github.com/nimsandu/spicetify-bloom/blob/rework/package.json#L30

@rxri
Copy link
Member

rxri commented Oct 18, 2023

use packageManager property. no need for preinstall script

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Oct 18, 2023 •
edited
Loading

packageManager property doesn't force to use specified manager

@rxri
Copy link
Member

rxri commented Oct 18, 2023

and use engines and engine-strict option in .npmrc

@theRealPadster theRealPadster merged commit b94c8c9 into spicetify:main Oct 18, 2023
5 checks passed
@SunsetTechuila SunsetTechuila deleted the actions branch October 19, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theRealPadster theRealPadster theRealPadster left review comments

@rxri rxri rxri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SunsetTechuila @theRealPadster @rxri