Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react types to 18.2.0 #671

Merged
merged 2 commits into from
Dec 10, 2023
Merged

feat: update react types to 18.2.0 #671

merged 2 commits into from
Dec 10, 2023

Conversation

theRealPadster
Copy link
Member

No description provided.

@theRealPadster theRealPadster requested a review from a team as a code owner December 9, 2023 23:10
@theRealPadster theRealPadster requested review from CharlieS1103 and removed request for a team December 9, 2023 23:10
@theRealPadster theRealPadster changed the title Update React types to 18.2.0 chore: update react types to 18.2.0 Dec 9, 2023
@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented Dec 9, 2023

react 18 is not fully backward compatible
and ofc all of its new features definitely aren't because they are new

@theRealPadster
Copy link
Member Author

react 18 is not fully backward compatible and ofc all of its new features definitely aren't because they are new

Don't think it matters? Newer versions of marketplace would be meant for newer versions of Spicetify/Spotify, so should only make sure the types are up to date.

@rxri rxri changed the title chore: update react types to 18.2.0 feat: update react types to 18.2.0 Dec 10, 2023
@rxri rxri merged commit d7e3528 into main Dec 10, 2023
6 of 7 checks passed
@rxri rxri deleted the chore/deps branch December 10, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants