Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snippets): improve Smooth Progress/Volume Bar code #680

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

theRealPadster
Copy link
Member

@theRealPadster theRealPadster commented Jan 24, 2024

It was using the default ease timing function, so while it was smoother, it still had definite start/stop points. This makes it a fully smooth linear transition with no discernable steps.

@theRealPadster theRealPadster requested a review from a team as a code owner January 24, 2024 15:27
@theRealPadster theRealPadster requested review from SunsetTechuila and removed request for a team January 24, 2024 15:27
Copy link
Contributor

@SunsetTechuila SunsetTechuila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this will be better:

@property --progress-bar-transform {
  inherits: true;
  initial-value: 0%;
  syntax: '<percentage>';
}
.progress-bar {
    transition: --progress-bar-transform 1s linear !important;
}
.progress-bar:hover, .progress-bar:active {
    transition-duration: 150ms !important;
}

@theRealPadster
Copy link
Member Author

Hmm, okay, but that makes it do the jittery thing when you hover over it.

@theRealPadster
Copy link
Member Author

Seems like if you take out the :hover bit and leave the :active, it still jumps fine when you click the bar, but stays smooth on hover.

@SunsetTechuila
Copy link
Contributor

SunsetTechuila commented Jan 24, 2024

Hmm, okay, but that makes it do the jittery thing when you hover over it.

You can wait for this to be merged then
spicetify/cli#2782

@theRealPadster
Copy link
Member Author

You can wait for this to be merged then spicetify/spicetify-cli#2782

I think it works well enough if you remove the :hover part. Don't really wanna be reliant on the css map being up to date if not needed.

@SunsetTechuila
Copy link
Contributor

as you wish

@SunsetTechuila SunsetTechuila changed the title fix(snippets): make smooth-progress-bar snippet actually smooth fix(snippets): improve Smooth Progress/Volume bar code Jan 24, 2024
@theRealPadster theRealPadster changed the title fix(snippets): improve Smooth Progress/Volume bar code fix(snippets): improve Smooth Progress/Volume Bar code Jan 24, 2024
@theRealPadster theRealPadster merged commit 5564b64 into main Jan 24, 2024
5 checks passed
@theRealPadster theRealPadster deleted the fix/smooth-progress-bar branch January 24, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants