Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: update active-model using JSON::Serializable #21

Merged
merged 12 commits into from
Mar 8, 2022
Merged

refactor!: update active-model using JSON::Serializable #21

merged 12 commits into from
Mar 8, 2022

Conversation

caspiano
Copy link
Contributor

Thanks @dukeraphaelng!

@dukenguyenxyz
Copy link
Contributor

dukenguyenxyz commented Feb 21, 2021 •
edited
Loading

Currently throwing the following compiler

Error: can't annotate @id in RethinkORM::Lock because it was first defined in RethinkORM::Base

This is due to the following breaking change in 0.36.0
crystal-lang/crystal#9502

@dukenguyenxyz dukenguyenxyz mentioned this pull request Feb 21, 2021
Closed
@dukenguyenxyz
Copy link
Contributor

dukenguyenxyz commented Mar 24, 2021 •
edited
Loading

I have no idea why name_was is getting serialised https://travis-ci.org/github/spider-gazelle/rethinkdb-orm/builds/764191628#L255-L264

All specs even the _was related one passed on active-model branch https://github.com/spider-gazelle/active-model/tree/json_yaml

@{{name}}_was is declared twice, here and here, and in the second one, JSON annotation is not present, however I cannot add the annotation there, the compiler yells that I cannot annotate an inherited instance_var

@caspiano

@caspiano caspiano self-assigned this Aug 3, 2021
@caspiano caspiano added the enhancement New feature or request label Aug 3, 2021
@caspiano
Copy link
Contributor Author

caspiano commented Aug 3, 2021

@kimburgess @dukeraphaelng
There seems to be an issue with redefining annotations when inheriting a model that has defined an attribute. Any ideas?

@dukenguyenxyz
Copy link
Contributor

@caspiano as mentioned above, this is due to #21 (comment)

@dukenguyenxyz dukenguyenxyz self-assigned this Aug 9, 2021
@kimburgess kimburgess mentioned this pull request Aug 12, 2021
Merged
@caspiano caspiano changed the title chore: update active-model refactor!: update active-model using JSON::Serializable Mar 8, 2022
@caspiano caspiano merged commit 607951f into master Mar 8, 2022
@caspiano caspiano deleted the chore/update-active-model branch March 8, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caspiano caspiano

@dukenguyenxyz dukenguyenxyz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caspiano @dukenguyenxyz