Update GOMAXPROCS configuration #4013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lou-lan
force-pushed
the
fix/GOMAXPROCS
branch
from
87e65a7
to
d3c1b73
Compare
weizhoublue
reviewed
Sep 4, 2024
| if currentP > int(controllerContext.Cfg.GoMaxProcs) { | ||
| p := runtime.GOMAXPROCS(int(controllerContext.Cfg.GoMaxProcs)) | ||
| logger.Sugar().Infof("Change max golang procs to %d", p) | ||
| if _, err := maxprocs.Set(maxprocs.Min(controllerContext.Cfg.GoMaxProcs)); err != nil { |
There was a problem hiding this comment.
1 是否有日志，能看到 设置效果
2 代码中 简短的 comment。说明下 设置为多少了
There was a problem hiding this comment.
{"level":"INFO","ts":"2024-09-04T05:27:16.125Z","logger":"spiderpool-controller","caller":"cmd/daemon.go:74","msg":"maxprocs: Updating GOMAXPROCS=1: using minimum allowed GOMAXPROCS"}
调高 limit，GOMAXPROCS 也相应增加
{"level":"INFO","ts":"2024-09-04T05:28:26.389Z","logger":"spiderpool-controller","caller":"cmd/daemon.go:74","msg":"maxprocs: Updating GOMAXPROCS=2: determined from CPU quota"}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4013 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 51 51
Lines 4514 4514
=======================================
Hits 3649 3649
Misses 699 699
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. |
lou-lan
force-pushed
the
fix/GOMAXPROCS
branch
2 times, most recently
from
883d2c4
to
09884b1
Compare
weizhoublue
added
cherrypick-release-v0.8
- Replace manual GOMAXPROCS setting with maxprocs package for improved handling. - Log a warning if setting GOMAXPROCS fails. - Ensure min value is used when setting max procs from configuration. Signed-off-by: lou-lan <loulan@loulan.me>
lou-lan
force-pushed
the
fix/GOMAXPROCS
branch
from
09884b1
to
6d241a4
Compare
weizhoublue
added
cherrypick-release-v1.0
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Update GOMAXPROCS configuration Signed-off-by: robot <tao.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3993, Update GOMAXPROCS configuration