Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pod mutating webhook to auto inject the pod network resources #4179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cyclinder
Copy link
Collaborator

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4177

Special notes for your reviewer:

@cyclinder cyclinder marked this pull request as draft October 17, 2024 11:02
Signed-off-by: cyclinder <qifeng.guo@daocloud>
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 18.56287% with 136 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (79d01ce) to head (5eb5a2a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/podmanager/utils.go 23.66% 96 Missing and 4 partials ⚠️
pkg/podmanager/pod_webhook.go 0.00% 36 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4179      +/-   ##
==========================================
- Coverage   80.39%   78.56%   -1.84%     
==========================================
  Files          51       52       +1     
  Lines        5637     5804     +167     
==========================================
+ Hits         4532     4560      +28     
- Misses        939     1073     +134     
- Partials      166      171       +5     
Flag Coverage Δ
unittests 78.56% <18.56%> (-1.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/podmanager/pod_manager.go 94.38% <ø> (ø)
pkg/podmanager/pod_webhook.go 0.00% <0.00%> (ø)
pkg/podmanager/utils.go 30.00% <23.66%> (-28.63%) ⬇️

... and 1 file with indirect coverage changes

@cyclinder cyclinder marked this pull request as ready for review October 18, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a mutating webhook for pods to auto inject the pod network resources
1 participant