Fix the clock skew calculation in auth tokens for IAM-based authentication with AWS RDS #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
requested review from
evan2645,
azdagron,
MarcosDY and
rturner3
as code owners
- Use the newly added clockSkew constant Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
azdagron
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function isExpired() is used to know if the current cached token used in IAM-based authentication with AWS RDS backed databases is expired or not.
It's currently subtracting a clock skew to the current time, while it should be adding it so the comparison with the expiration time returns >= 0 to indicate that is expired within the skew.
This is done so it's considered expired some time before it really expires, to avoid using a cached token when it's very close to expiration.
I also took the opportunity to remove the tokenGetter interface that was not being used.