Various deprecation fixes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This section of code confuses me because it uses a long-winded method to append the random clause to the orders even though orders are normally appended anyway. I'm currently testing against AR 5.2.1 but I'm fairly sure this has always been the case. I do recall a bug in Squeel that caused orders to be prepended instead but I doubt that was the reason the code was written this way. In any case, simply appending in the usual manner deals with the deprecation message.
Raw SQL strings need to be wrapped in Arel.sql now.
|
The CI failues are not my fault. |
|
Thanks for the PR, can hopefully check this out sometime next week :) |
|
@chewi sorry this took so long, when you made this PR we had just had our first child and I was low and sleep and spare time, plus I was/am really out of practice with Ruby. In working on #40 we got the tests passing so I'm gonna merge your PR now and I'll fix if there are any issues that come up after the merge. Thanks for the help! |
|
No worries, I've been there. Second one on the way in August actually. I moved to another company shortly after filing this but I still occasionally work with Rails so your merge is still appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please look closely at the second commit as I'm not sure about it.