-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to the latest version of ProtoData #12
Conversation
Bring back `@External` annotation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Oleg-Melnik please see my comments.
Otherwise, LGTM.
val sdterrContent = stderr.toString() | ||
val errorFound = sdterrContent.contains(expectedExceptionMessage) | ||
|
||
System.err.println(sdterrContent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's kill the debug output.
|
||
System.err.println(sdterrContent) | ||
|
||
//check(errorFound) { sdterrContent } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
proto-extension/build.gradle.kts
Outdated
// for details. | ||
tasks.configureEach { | ||
if (name == "kspKotlin") { | ||
mustRunAfter(tasks.named("launchProtoData")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have launchProtoData
in this module at all.
… unnecessary build scripts. Remove usage of `System.out`.
@armiol Please re-review. |
The main goal of this PR is to migrate to the latest version of ProtoData.
Also, the license header is updated to use the correct URL to Apache license.