Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: spiraldb/fsst
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.1
Choose a base ref
...
head repository: spiraldb/fsst
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.2.2
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Aug 21, 2024

  1. remove spurious check (#18)

    @a10y
    a10y committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    0ee78e0 View commit details
    Browse the repository at this point in the history

  2. implement second bitmap, ~2x speedup for train (#21) 

    ![image](https://github.com/user-attachments/assets/5a30710f-8025-4708-ad74-eee6dd14187b)

^ this is a sad flamegraph. `bzero` is not a fun place to be spending
60% of your time.



![image](https://github.com/user-attachments/assets/fbe55d00-d7fd-4999-83be-3d9b8e6b48b5)


How did we get from one to two?

1. Avoid initializing our `counts1` and `counts1` vectors
2. Implement a second bitmap index that limits our outer-loop iterations
in `optimize`. Because `counts1` and `counts2` are not initialized, we
check the bitmap before all accesses

This also gives us another 2x speedup on the train benchmark, which is
nice
    @a10y
    a10y committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d15cc4e View commit details
    Browse the repository at this point in the history

  3. chore: release v0.2.2 (#19) 

    ## 🤖 New release
* `fsst-rs`: 0.2.1 -> 0.2.2

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.2.2](v0.2.1...v0.2.2) -
2024-08-21

### Other
- implement second bitmap, ~2x speedup for train
([#21](#21))
- remove spurious check
([#18](#18))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @github-actions
    github-actions[bot] committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ced11ef View commit details
    Browse the repository at this point in the history
Loading