Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin 2.0.0 #782

Merged
merged 59 commits into from
Jun 13, 2024
Merged

Kotlin 2.0.0 #782

merged 59 commits into from
Jun 13, 2024

Conversation

Daeda88
Copy link
Contributor

@Daeda88 Daeda88 commented Jun 3, 2024

Daeda88 added 25 commits June 3, 2024 12:22
@Daeda88
WIP 2.0
5f9147e
@Daeda88
Base module compiling
044b248
@Daeda88
Scientific
08a29ad
@Daeda88
Fixing for Compose
c58a289
@Daeda88
Gradle syncing for most modules
374dc89 
Also split up Android plugin into two plugins
@Daeda88
Remaining gradle files for modules
396cfc2
@Daeda88
Fixed expect/actuals
a68b9e7
@Daeda88
Fixed kapt issue
e01d034
@Daeda88
Fixed Publish/Compiling tests
410b0c6 
Two tests failing on iOS still
@Daeda88
API Dump + Lint
5a39e11
@Daeda88
Fixed broken iOS tests
e102e17
@Daeda88
Lint fixes on plugin
83945ca
@Daeda88
Plugin package fixes
9f1d720
@Daeda88
Ignore .kotlin folder
c0ab5a0
@Daeda88
More api dump
8564cc4
@Daeda88
Align emulator tests with minSDK
26a7da5
@Daeda88
Fixed signing key path for publication
4411978
@Daeda88
Making publish logic more readable
47280ae
@Daeda88
Fixed version format
a59855b
@Daeda88
Fix typo
1dd15ea
@Daeda88
Fixes for UITests running on wrong target
2de07b8
@Daeda88
Adding New Module fixes
538127e
@Daeda88
Example building for iOS
ec2735d
@Daeda88
Moving embedding to plugin and got all Gradle building
bb65780 
TODO: Weird android issue
@Daeda88
Move to Material3
9dbce59
@Daeda88 Daeda88 marked this pull request as ready for review June 7, 2024 13:17
thoutbeckers
thoutbeckers requested changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@thoutbeckers thoutbeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only JS runBlocking change is needed.

base/src/jsMain/kotlin/runBlocking.kt Outdated Show resolved Hide resolved
example/build.gradle.kts Show resolved Hide resolved
@ci-splendo
Copy link
Contributor

ci-splendo commented Jun 12, 2024 •
edited
Loading

Code coverage

File Coverage [0.00%]
architecture-compose/src/main/kotlin/com/splendo/kaluga/architecture/compose/navigation/BottomSheetNavigator.kt 0.00%
architecture-compose/src/main/kotlin/com/splendo/kaluga/architecture/compose/navigation/BottomSheetNavigatorState.kt 0.00%
architecture-compose/src/main/kotlin/com/splendo/kaluga/architecture/compose/navigation/BottomSheetRoute.kt 0.00%
architecture-compose/src/main/kotlin/com/splendo/kaluga/architecture/compose/navigation/BottomSheetRouteController.kt 0.00%
architecture-compose/src/main/kotlin/com/splendo/kaluga/architecture/compose/navigation/RouteController.kt 0.00%
architecture-compose/src/main/kotlin/com/splendo/kaluga/architecture/compose/viewModel/ViewModelComposable.kt 0.00%
Total Project Coverage 61.69%

@Daeda88 Daeda88 merged commit a548049 into develop Jun 13, 2024
58 of 63 checks passed
@Daeda88 Daeda88 deleted the feature/kotlin-2.0 branch June 13, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoutbeckers thoutbeckers thoutbeckers approved these changes

@dasdranagon dasdranagon dasdranagon approved these changes

@avdyushin avdyushin avdyushin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Daeda88 @ci-splendo @thoutbeckers @dasdranagon @avdyushin