Enable automatic cleanup for local file systems #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/splitgraph/seafowl into local-file-system-automatic_cleanup
…-file-system-automatic_cleanup
gruuya
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the way to delete a "directory" through the ObjectStore interface is to call
listwith the directory path as prefix and then pipe that todelete_stream.This is the correct way to do this for object storage since "directories" don't really exist and the path is just a prefix to individual objects.
But for actual filesystems directories are actual inodes themselves in the filesystem which should be cleaned up. This flag enables the automatic cleanup of empty directories when deleting files.