fix: dump dunamai to 1.5.5 version #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having "*" in pyproject.toml for dunamai leads to installation of the latest version after running `poetry build`. And in case of new dunamai release the new version will be installed which can break everything. Related issue: python-poetry/poetry#1307
ghost
requested review from
|
Expected release notes (by @arys-splunk) fixes: others (will not be included in Semantic-Release notes):
|
Codecov Report
@@ Coverage Diff @@
## main #312 +/- ##
=======================================
Coverage 76.80% 76.80%
=======================================
Files 28 28
Lines 1953 1953
=======================================
Hits 1500 1500
Misses 453 453 Continue to review full report at Codecov.
|
harshpatel-crest
approved these changes
Aug 10, 2021
|
🎉 This PR is included in version 5.6.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having "*" in pyproject.toml for dunamai leads to installation
of the latest version after running
poetry build. Lock file isignored in this case.
And in case of new dunamai release the new version will be installed
which can break everything.
Related issue: python-poetry/poetry#1307