fix: better error messages during the runs #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the logging for this GitHub Action so developer can understand most of the thing from the console output without a need to look into the HTML report. This commit also removes couple of simple functions and embeds their functionality into the main function without losing readability. The HTML report will be anyways downloaded and stored for Splunk repositories.
artemrys
force-pushed
the
fix/better-error-message
branch
from
1a86240
to
2e674b4
Compare
mbruzda-splunk
previously approved these changes
Sep 6, 2023
…ct-api-action into fix/better-error-message
mkolasinski-splunk
previously approved these changes
Sep 20, 2023
mbruzda-splunk
previously approved these changes
Sep 20, 2023
…ct-api-action into fix/better-error-message
artemrys
dismissed stale reviews from mbruzda-splunk and mkolasinski-splunk
via
74ef24d
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created to address the lack of logging when there is a failure in the AppInspect API report, an example can be found here: https://github.com/splunk/splunk-dbx-add-on-for-snowflake/actions/runs/6038070637/job/16410674911.
This commit improves the logging for this GitHub Action so developer can understand most of the thing from the console output without a need to look into the HTML report.
This commit also removes couple of simple functions and embeds their functionality into the main function without losing readability.
The HTML report will be anyways downloaded and stored for Splunk repositories.
This is how it looks like when something is not working: https://github.com/splunk/splunk-add-on-for-google-workspace/actions/runs/6098067676/job/16548742124?pr=491
This is how it looks like when everything is okay: https://github.com/splunk/splunk-add-on-for-google-workspace/actions/runs/6098067676/job/16549160040?pr=491