Initial implementation of updating offline caching and loading #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verhaul here - but need to update the serialization of these objects as the json api objects are different and far too large.
patel-bhavin
previously approved these changes
Sep 5, 2024
complicated and pervasive than they needed to be. This will likely wind up being the last commit in this branch and a new one with simpler changes will likely be created.
…ntentctl into fix_offline_enrichment
|
Closing this PR in favor of a simpler one with less changes here: #291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big overhaul here - but need to update the serialization of these objects as the json api objects are different and far too large.
We need to decide if we want this level of complexity for these objects, which is especially nice if we will ever use other fields for these objects.
If this complexity is to much, we can also use
extras="ignore"for the mode and only create the fields that we actually care about.This is a draft as output api objects are still incorrect (they are far too large and include all the extra fields, so the serialization logic must be updated).