Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing on Datasource changes #301

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Testing on Datasource changes #301

wants to merge 1 commit into from

Conversation

ljstella
Copy link
Contributor

@ljstella ljstella commented Oct 7, 2024

When we calculate changes between two branches in order to run tests, we currently do not catch data source object changes as content dependencies. Following the same path in which we calculate macros and lookups as being content dependencies, this PR will attempt to change the diff calculation to include data source object changes.

Notably, this will then trigger the testing for each of these detections when we have an "Auto Update TA" PR like so: splunk/security_content#3154. (See Note at end)

This testing will provide the confidence and verification that such changes can be merged without issues.

Note:
Those PRs currently don't update contentctl.yml, which appears to still be used for testing, so until we decide how to reconcile those here, or update the code powering those PRs to also make those changes, this will trigger tests but still using the old TAs. We also don't really have any testing afaict to confirm that the TA version change does not alter sourcetypes or fields- those will hopefully become apparent via the actual testing, but that's not necessarily guaranteed depending on the original GDI mechanism

@ljstella ljstella self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant