Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update contributor-assistant/github-action action to v2.6.1 - abandoned #2602

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
16d097f
chore(deps): update dependency mkdocs to v1.6.1 (#2585)
renovate[bot] Sep 18, 2024
8b9b90c
chore(deps): update dependency lovely-pytest-docker to v1 (#2587)
renovate[bot] Sep 18, 2024
ea9b74e
chore(deps): update dependency setuptools to v73
mstopa-splunk Sep 18, 2024
2c60502
hore(deps): update contributor-assistant/github-action action to v2.5.1
mstopa-splunk Sep 18, 2024
cea85df
chore(deps): update dependency pyyaml to v6.0.2
mstopa-splunk Sep 18, 2024
b16125f
Poetry update
mstopa-splunk Sep 18, 2024
4c4ff51
chore(deps): update splunk/addonfactory-test-matrix-action action to v2
mstopa-splunk Sep 18, 2024
bb90c10
chore(deps): update splunk/addonfactory-test-matrix-action action to …
renovate[bot] Sep 19, 2024
70103a3
chore(deps): update contributor-assistant/github-action action to v2.…
renovate[bot] Sep 23, 2024
207fc13
chore(deps): update dependency mkdocs-material to v9.5.36 (#2596)
renovate[bot] Sep 23, 2024
76c980c
feat: Added an env variable to set source as 'sc4s' (#2581)
cwadhwani-splunk Sep 24, 2024
8a4fe5c
chore(deps): update dependency mkdocs-material to v9.5.38 (#2599)
renovate[bot] Sep 26, 2024
5e9cf16
feat: add gdb to the image (#2580)
mstopa-splunk Sep 26, 2024
7dec478
fix: filter fortigate (#2579)
mstopa-splunk Sep 26, 2024
538be9b
feat: load host IP from proxied source IP (#2566)
mstopa-splunk Sep 26, 2024
03636e6
docs: Updated the issue template with a note of creating the support …
cwadhwani-splunk Sep 26, 2024
3f3835c
SC4S release
mstopa-splunk Sep 26, 2024
f569af9
revert adding gdb to the image
mstopa-splunk Sep 26, 2024
528107b
chore(deps): update contributor-assistant/github-action action to v2.6.1
renovate[bot] Sep 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/ISSUE_TEMPLATE/bug-escalation-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ assignees: ''

---

**Note: If your issue is not a bug or a feature request, please raise a support ticket through our support portal (Splunk.com > Support > Support Portal). This will help us resolve your issue more efficiently and provide you with better assistance. For more information on how to work with the Splunk Support, please refer to [this guide](https://splunk.my.site.com/customer/s/article/Working-with-Support-and-the-Support-Portal).**

**Was the issue replicated by support?**

**What is the sc4s version ?**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ assignees: ''

---

**Note: If your issue is not a bug or a feature request, please raise a support ticket through our support portal (Splunk.com > Support > Support Portal). This will help us resolve your issue more efficiently and provide you with better assistance. For more information on how to work with the Splunk Support, please refer to [this guide](https://splunk.my.site.com/customer/s/article/Working-with-Support-and-the-Support-Portal).**

**What is the sc4s version?**

**Is there a pcap available? If so, would you prefer to attach it to this issue or send it to Splunk support?**
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/agreements.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: "CLA Assistant"
if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the CLA Document and I hereby sign the CLA') || github.event_name == 'pull_request_target'
# Alpha Release
uses: contributor-assistant/github-action@v2.4.0
uses: contributor-assistant/github-action@v2.6.1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# the below token should have repo scope and must be manually added by you in the repository's secret
Expand All @@ -43,7 +43,7 @@ jobs:
- name: "COC Assistant"
if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the Code of Conduct and I hereby accept the Terms') || github.event_name == 'pull_request_target'
# Alpha Release
uses: contributor-assistant/github-action@v2.4.0
uses: contributor-assistant/github-action@v2.6.1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# the below token should have repo scope and must be manually added by you in the repository's secret
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-lite.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
type=ref,event=tag
- name: matrix
id: matrix
uses: splunk/addonfactory-test-matrix-action@v1.13.1
uses: splunk/addonfactory-test-matrix-action@v2.1.8

security-fossa-scan:
continue-on-error: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
type=ref,event=tag
- name: matrix
id: matrix
uses: splunk/addonfactory-test-matrix-action@v1.13.1
uses: splunk/addonfactory-test-matrix-action@v2.1.8

security-fossa-scan:
continue-on-error: true
Expand Down
10 changes: 10 additions & 0 deletions docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,16 @@ A syntax error will cause the runtime process to abort in the "preflight" phase

To update your changes, restart SC4S.

### Set source value as 'sc4s'

User can set the source field value to 'sc4s' by using the `SC4S_SET_SOURCE_AS_SC4S` variable.

**Note:** If the source field value is specified in a local parser or the splunk_metadata.csv file, it will take precedence over the `SC4S_SET_SOURCE_AS_SC4S` variable and overwrite the source field value.

| Variable | Values | Description |
|----------|---------------|-------------|
| SC4S_SET_SOURCE_AS_SC4S | yes or no(default) | Set the source field value to 'sc4s'. |

## Drop all data by IP or subnet (deprecated)

Using `vendor_product_by_source` to null queue is now a deprecated task. See the supported method for dropping data in [Filtering events from output](https://splunk.github.io/splunk-connect-for-syslog/main/sources/#filtering-events-from-output).
Expand Down
5 changes: 5 additions & 0 deletions package/etc/conf.d/conflib/_splunk/splunkfields.conf
Original file line number Diff line number Diff line change
Expand Up @@ -128,3 +128,8 @@ filter f_is_source_identified{
filter f_is_agg{
tags("agg");
};

filter f_is_proxy_ip{
"$HOST" eq "$SOURCEIP"
and "$PROXIED_SRCIP" ne ""
};
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@ block parser app-syslog-fortigate_fortios() {
};
};
};

application fortinet_fortios[sc4s-syslog] {
filter {
(
message("eventtype=")
or message("time=")
)
and message("devid=")
};
parser { app-syslog-fortigate_fortios(); };
};
Original file line number Diff line number Diff line change
Expand Up @@ -133,5 +133,15 @@ block parser app-syslog-fortigate_fortiweb() {
};
};
application app-syslog-fortigate_fortiweb[sc4s-syslog] {
filter {
(
message('eventtime=')
or (
message('date=')
and message('time=')
)
)
and message('device_id=')
};
parser { app-syslog-fortigate_fortiweb(); };
};
1 change: 1 addition & 0 deletions package/etc/conf.d/sources/internal.conf
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ source s_internal {
or match("Syslog connection closed; fd=" value("MESSAGE"))
or match("Syslog connection accepted; fd=" value("MESSAGE"))
or match("xml-parser failed; " value("MESSAGE"))
or match("Initializing PROXY protocol source driver" value("MESSAGE"))
};
rewrite(r_set_dest_splunk_null_queue);
};
Expand Down
25 changes: 25 additions & 0 deletions package/etc/conf.d/sources/source_syslog/plugin.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,13 @@ source s_{{ port_id }} {
);
};
{%- endif %}

{%- if use_proxy_connect == True %}
rewrite {
set("$PROXIED_SRCIP", value("HOST") condition(filter(f_is_proxy_ip)) );
};
{%- endif %}

if {
if {
parser {
Expand Down Expand Up @@ -288,6 +295,11 @@ source s_{{ port_id }} {
};
};

{%- if set_source_sc4s == True %}
rewrite {
set("sc4s", value(".splunk.source"));
};
{%- endif %}

rewrite {
set($FACILITY, value("fields.sc4s_syslog_facility") condition(match('facility' template('`SC4S_DEST_SPLUNK_INDEXED_FIELDS`') type(string) flags(substring))));
Expand Down Expand Up @@ -391,6 +403,13 @@ source s_{{ port_id }} {
{%- endif %}
{%- endfor %}
};

{%- if use_proxy_connect == True %}
rewrite {
set("$PROXIED_SRCIP", value("HOST") condition(filter(f_is_proxy_ip)) );
};
{%- endif %}

{%- if vendor and product %}
parser {
p_set_netsource_fields(
Expand Down Expand Up @@ -475,6 +494,12 @@ source s_{{ port_id }} {
parser(app-group-sc4s-fallback);
};

{%- if set_source_sc4s == True %}
rewrite {
set("sc4s", value(".splunk.source"));
};
{%- endif %}

rewrite {
set($FACILITY, value("fields.sc4s_syslog_facility") condition(match('facility' template('`SC4S_DEST_SPLUNK_INDEXED_FIELDS`') type(string) flags(substring))));
set($LEVEL, value("fields.sc4s_syslog_severity") condition(match('severity' template('`SC4S_DEST_SPLUNK_INDEXED_FIELDS`') type(string) flags(substring)) ));
Expand Down
1 change: 1 addition & 0 deletions package/etc/conf.d/sources/source_syslog/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,5 +133,6 @@ def normalize_env_variable_input(env_variable: str):
ebpf_no_sockets=int(os.getenv("SC4S_EBPF_NO_SOCKETS", 4)),
enable_parallelize=normalize_env_variable_input(f"SC4S_ENABLE_PARALLELIZE"),
parallelize_no_partitions=int(os.getenv(f"SC4S_PARALLELIZE_NO_PARTITION", 4)),
set_source_sc4s=normalize_env_variable_input("SC4S_SET_SOURCE_AS_SC4S"),
)
print(outputText)
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@ block parser app-syslog-fortigate_fortios() {
};
};
};

application fortinet_fortios[sc4s-syslog] {
filter {
(
message("eventtype=")
or message("time=")
)
and message("devid=")
};
parser { app-syslog-fortigate_fortios(); };
};
Original file line number Diff line number Diff line change
Expand Up @@ -133,5 +133,15 @@ block parser app-syslog-fortigate_fortiweb() {
};
};
application app-syslog-fortigate_fortiweb[sc4s-syslog] {
filter {
(
message('eventtime=')
or (
message('date=')
and message('time=')
)
)
and message('device_id=')
};
parser { app-syslog-fortigate_fortiweb(); };
};
Loading
Loading