Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Groovy-4-style range expressions #1958

Merged
merged 1 commit into from
May 20, 2024

Conversation

leonard84
Copy link
Member

fixes #1956

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.83%. Comparing base (2c7db77) to head (4556a97).
Report is 95 commits behind head on master.

Files Patch % Lines
...n/java/org/spockframework/util/ReflectionUtil.java 50.00% 3 Missing ⚠️
...org/spockframework/compiler/ConditionRewriter.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1958      +/-   ##
============================================
+ Coverage     80.44%   81.83%   +1.38%     
- Complexity     4337     4572     +235     
============================================
  Files           441      446       +5     
  Lines         13534    14337     +803     
  Branches       1707     1813     +106     
============================================
+ Hits          10888    11732     +844     
+ Misses         2008     1939      -69     
- Partials        638      666      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AndreasTu AndreasTu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@leonard84 leonard84 merged commit 52f8f9e into spockframework:master May 20, 2024
25 of 26 checks passed
@leonard84 leonard84 deleted the fix-1956 branch May 20, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spock breaks start-exclusive ranges
2 participants