Add GlobalTimeoutExtension and use it in specs #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use virtual threads for the timeout monitoring thread if available
AndreasTu
requested changes
Aug 17, 2024
| @@ -323,6 +322,11 @@ class TimedSpec extends Specification { | |||
|
|
|||
| @Timeout(value = 250, unit = MILLISECONDS) | |||
| def "I fail much faster"() { ... } | |||
|
|
|||
There was a problem hiding this comment.
Wouldn't it be better to convert that example into a real test, to be sure that the example is "working" at least syntactically.
There was a problem hiding this comment.
Yes, but in a separate PR. I'd like to get this merged soon to hopefully trace the hanging builds we've seen.
...-core/src/main/java/org/spockframework/runtime/extension/builtin/GlobalTimeoutExtension.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/spockframework/runtime/extension/builtin/GlobalTimeoutExtension.java
Show resolved
Hide resolved
AndreasTu
previously approved these changes
Aug 19, 2024
|
😬 https://github.com/spockframework/spock/actions/runs/10452252979/job/28940316954?pr=1986 is already running 1h+. Either we need to add it to fixtures too, or the problem lies somewhere in-betwee. |
|
@AndreasTu, thanks for the review. Could you approve the last commit? |
AndreasTu
approved these changes
Aug 19, 2024
|
Same job is stuck again, looks like it wasn't the fixtures either 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use virtual threads for the timeout monitoring thread if available