Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbeddedSpecRunner/Compiler ClassLoader support #1988

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

AndreasTu
Copy link
Member

EmbeddedSpecRunner and EmbeddedSpecCompiler now support the construction with a ClassLoader.
This allows the use of these classes in an OSGi environment, where the class imports in the embedded spec are not visible by the Spock OSGi bundle ClassLoader

@AndreasTu AndreasTu added this to the 2.4-M5 milestone Aug 18, 2024
@AndreasTu AndreasTu self-assigned this Aug 18, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.90%. Comparing base (2c7db77) to head (07202ed).
Report is 122 commits behind head on master.

Files with missing lines Patch % Lines
...c/main/groovy/spock/util/EmbeddedSpecRunner.groovy 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1988      +/-   ##
============================================
+ Coverage     80.44%   81.90%   +1.45%     
- Complexity     4337     4604     +267     
============================================
  Files           441      448       +7     
  Lines         13534    14417     +883     
  Branches       1707     1822     +115     
============================================
+ Hits          10888    11808     +920     
+ Misses         2008     1936      -72     
- Partials        638      673      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EmbeddedSpecRunner and EmbeddedSpecCompiler now support the construction with a ClassLoader.
This allows the use of these classes in an OSGi environment,
where the class imports in the embedded spec are not visible by the Spock OSGi bundle ClassLoader
@AndreasTu AndreasTu enabled auto-merge (squash) September 24, 2024 09:10
@AndreasTu AndreasTu merged commit cdc792b into spockframework:master Sep 24, 2024
25 of 26 checks passed
@AndreasTu AndreasTu deleted the EmbeddedSpecOSGi branch September 24, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants