forked from BDQ/deface
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERB in line comments break template rendering e.g. <% # comment %> #113
Comments
same here, override failling for https://github.com/spree/spree/blob/master/backend/app/views/spree/admin/taxons/edit.html.erb |
I encounter this same issue in 1-3-stable which uses deface 1.0.0 when I try to use deface to make a change to spree/admin/payment_methods/_form.html.erb because that view has an inline comment. additional info: |
bryanmtl
pushed a commit
to DynamoMTL/spree
that referenced
this issue
Nov 22, 2013
see spree/deface#113 for more info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was investigating some failures in spree_i18n build and tracked it down to deface overrides. For some reason every time we try to override something in a template, which has erb inline comments, with deface the rendering process breaks.
To reproduce you can place a partial like this in a fresh Spree 2.1 app:
app/views/spree/shared/_nav_bar.html.erb (this is overridden in spree_auth_devise)
You should get a very confusing SyntaxError. The same code doesn't generate any error in Spree 2.0.x (which runs Rails 3.2.x). I'm on ruby 2.0.0. Applying the comment like this however
<%# comment %>
doesn't error.Curious to know if you guys have any clue on what's happening here?
The text was updated successfully, but these errors were encountered: