Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Replace sun libraries with bouncycastle #2249

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Conversation

elefeint
Copy link
Contributor

Old sun crypto libraries have been modularized away from base.

Bouncy castle is MIT license, test scope, works well.

Fixes #2240.

meltsufin
meltsufin previously approved these changes Mar 12, 2020
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #2249 into master will decrease coverage by 8.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2249      +/-   ##
============================================
- Coverage     80.76%   72.62%   -8.14%     
+ Complexity     2275     2030     -245     
============================================
  Files           258      258              
  Lines          7398     7398              
  Branches        753      753              
============================================
- Hits           5975     5373     -602     
- Misses         1111     1680     +569     
- Partials        312      345      +33
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 72.62% <ø> (ø) 2030 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...a/spanner/repository/query/SpannerQueryMethod.java 0% <0%> (-100%) 0% <0%> (-6%)
...ure/secretmanager/SecretManagerPropertySource.java 0% <0%> (-100%) 0% <0%> (-7%)
...ository/config/FirestoreRepositoriesRegistrar.java 0% <0%> (-100%) 0% <0%> (-3%)
...sitory/support/FirestoreRepositoryFactoryBean.java 0% <0%> (-100%) 0% <0%> (-4%)
...pository/support/FirestoreQueryLookupStrategy.java 0% <0%> (-100%) 0% <0%> (-2%)
...figure/config/GcpConfigBootstrapConfiguration.java 0% <0%> (-100%) 0% <0%> (-2%)
...restore/repository/query/FirestoreQueryMethod.java 0% <0%> (-100%) 0% <0%> (-2%)
...ository/config/DatastoreRepositoriesRegistrar.java 0% <0%> (-100%) 0% <0%> (-3%)
...retmanager/SecretManagerPropertySourceLocator.java 0% <0%> (-100%) 0% <0%> (-2%)
...epository/config/SpannerRepositoriesRegistrar.java 0% <0%> (-100%) 0% <0%> (-3%)
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adf432...c124d82. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@elefeint elefeint merged commit b868377 into master Mar 13, 2020
@elefeint elefeint deleted the fix-firebase-keygen branch March 13, 2020 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CNF: sun.security.tools.keytool.CertAndKeyGen that RSAKeyGeneratorUtils uses
2 participants