Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Fix Secret Manager integration test flakiness #2294

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Fix Secret Manager integration test flakiness #2294

merged 1 commit into from
Mar 30, 2020

Conversation

dzou
Copy link
Contributor

@dzou dzou commented Mar 30, 2020

Fix the Secret Manager Integration Test flakiness; should fix the build.

@dzou dzou requested review from meltsufin and elefeint March 30, 2020 20:32
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #2294 into master will decrease coverage by 8.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2294      +/-   ##
============================================
- Coverage     80.95%   72.65%   -8.31%     
+ Complexity     2309     2059     -250     
============================================
  Files           258      258              
  Lines          7456     7456              
  Branches        762      762              
============================================
- Hits           6036     5417     -619     
- Misses         1100     1689     +589     
- Partials        320      350      +30     
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 72.65% <ø> (-0.03%) 2059.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...restore/repository/query/FirestoreQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...pository/support/FirestoreQueryLookupStrategy.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/FirestoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...sitory/support/FirestoreRepositoryFactoryBean.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...anager/GcpSecretManagerBootstrapConfiguration.java 0.00% <0.00%> (-90.91%) 0.00% <0.00%> (-3.00%)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f6386...9c217a4. Read the comment docs.

Copy link
Contributor

@elefeint elefeint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice! I was wondering if it was a flake; figured I'd let my commit run through to check.

@dzou dzou merged commit 40284d3 into master Mar 30, 2020
@dzou dzou deleted the fix-secret-it branch March 30, 2020 21:03
@dzou
Copy link
Contributor Author

dzou commented Mar 30, 2020

Ah, nice! I was wondering if it was a flake; figured I'd let my commit run through to check.

Thanks, hope this works :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants